Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5758 - link element copy preview image #4569

Merged
merged 6 commits into from
Nov 23, 2023
Merged

BC-5758 - link element copy preview image #4569

merged 6 commits into from
Nov 23, 2023

Conversation

hoeppner-dataport
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport commented Nov 21, 2023 •
edited
Loading

Description

When ... a LinkElement

  • copying: an existing preview-image needs to be copied, too and the internal imageUrl needs to get updated
  • deleting: the file-storage needs to get informed, that associated files get deleted, too
  • updating: nothing needs to be done regarding this bugfix.

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hoeppner-dataport hoeppner-dataport enabled auto-merge (squash) November 23, 2023 08:52
@hoeppner-dataport hoeppner-dataport merged commit e563729 into main Nov 23, 2023
47 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-5758-link-element-copy-preview-image branch November 23, 2023 09:00
uidp pushed a commit that referenced this pull request Nov 23, 2023
@hoeppner-dataport @uidp
BC-5758 - link element copy preview image (#4569)
d45bf0d 
When a LinkElement is
copied: if it has a preview-image, it gets copied and the internal imageUrl is being updated
deleted: the file-storage will deleted associated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uidp uidp uidp approved these changes

@Metauriel Metauriel Metauriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoeppner-dataport @Metauriel @uidp